From af9da714f7abc75d2652948563b1b2f4aab7e282 Mon Sep 17 00:00:00 2001 From: Noah Knegt Date: Fri, 31 Mar 2023 12:29:04 +0200 Subject: [PATCH] Remove the complex looping Signed-off-by: Noah Knegt --- roles/docker/tasks/check_version.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/roles/docker/tasks/check_version.yml b/roles/docker/tasks/check_version.yml index f5b98aa..205e8ac 100644 --- a/roles/docker/tasks/check_version.yml +++ b/roles/docker/tasks/check_version.yml @@ -19,12 +19,10 @@ state: present - name: Check if latest version is stable - shell: "curl -s https://api.github.com/repos/docker/cli/tags | jq -r '.[{{ item }}].name' | grep -E -o '[0-9]+\\.[0-9]+\\.[0-9]+\\-?'" - register: docker_latest_version_stable - until: docker_latest_version_stable.stdout is not search('-') - loop: "{{ range(0, 10) | list }}" + shell: "curl -s https://api.github.com/repos/docker/cli/tags | jq -r '.[0].name' | grep -E -o '[0-9]+\\.[0-9]+\\.[0-9]+\\-?'" + register: docker_latest_version - name: Compare versions set_fact: docker_update: true - when: docker_version.stdout is not defined or docker_version.stdout != docker_latest_version_stable.stdout + when: docker_version.stdout is not defined or (docker_version.stdout != docker_latest_version.stdout and docker_latest_version.stdout is not search("-"))