Rename logger to logging and fix formatting

Signed-off-by: Noah Knegt <git@noahknegt.com>

build.rs

@@ -9,11 +9,15 @@ fn main() {
 
     // create an UEFI disk image (optional)
     let uefi_path = out_dir.join("uefi.img");
-    bootloader::UefiBoot::new(&kernel).create_disk_image(&uefi_path).unwrap();
+    bootloader::UefiBoot::new(&kernel)
+        .create_disk_image(&uefi_path)
+        .unwrap();
 
     // create a BIOS disk image
     let bios_path = out_dir.join("bios.img");
-    bootloader::BiosBoot::new(&kernel).create_disk_image(&bios_path).unwrap();
+    bootloader::BiosBoot::new(&kernel)
+        .create_disk_image(&bios_path)
+        .unwrap();
 
     // pass the disk image paths as env variables to the `main.rs`
     println!("cargo:rustc-env=UEFI_PATH={}", uefi_path.display());

kernel/src/lib.rs

@@ -1,11 +1,11 @@
 #![no_std]
 
 use bootloader_api::{
+    BootInfo,
     config::{BootloaderConfig, Mapping},
-    BootInfo
 };
 
-mod logger;
+mod logging;
 
 pub static BOOTLOADER_CONFIG: BootloaderConfig = {
     let mut config = BootloaderConfig::new_default();
@@ -13,25 +13,27 @@ pub static BOOTLOADER_CONFIG: BootloaderConfig = {
     config
 };
 
-
 pub fn main(boot_info: &'static mut BootInfo) -> ! {
     let info = boot_info.framebuffer.as_ref().unwrap().info();
     let buffer = boot_info.framebuffer.as_mut().unwrap().buffer_mut();
 
-    logger::init_logger(buffer, info);
+    logging::init_logger(buffer, info);
 
     log::info!("Hello World from KERNEL");
     log::debug!("ADDING 1 & 6, result == {}", add(1, 6));
 
     // Endless loop as the kernel must stay running
+    #[allow(clippy::empty_loop)]
     loop {}
 }
 
 #[panic_handler]
 #[cfg(not(test))]
 fn panic(info: &core::panic::PanicInfo) -> ! {
-    logger::force_unlock();
+    logging::force_unlock();
-    log::error!("{}", info);
+    log::error!("{info}");
+
+    #[allow(clippy::empty_loop)]
     loop {}
 }
 

kernel/src/logging/framebuffer.rs

@@ -2,7 +2,7 @@ use bootloader_api::info::{FrameBufferInfo, PixelFormat};
 use core::{fmt, ptr};
 use font_constants::BACKUP_CHAR;
 use noto_sans_mono_bitmap::{
-    get_raster, get_raster_width, FontWeight, RasterHeight, RasterizedChar,
+    FontWeight, RasterHeight, RasterizedChar, get_raster, get_raster_width,
 };
 
 /// Additional vertical space between lines
@@ -130,7 +130,7 @@ impl FrameBufferWriter {
                 // set a supported (but invalid) pixel format before panicking to avoid a double
                 // panic; it might not be readable though
                 self.info.pixel_format = PixelFormat::Rgb;
-                panic!("pixel format {:?} not supported in logger", other)
+                panic!("pixel format {other:?} not supported in logger")
             }
         };
         let bytes_per_pixel = self.info.bytes_per_pixel;

kernel/src/logging/logger.rs

@@ -11,21 +11,21 @@ static LOGGER: OnceCell<LockedLogger> = OnceCell::uninit();
 /// A logger instance protected by a spinlock.
 struct LockedLogger {
     framebuffer: Option<Spinlock<framebuffer::FrameBufferWriter>>,
-    serial: Option<Spinlock<serial::SerialPort>>
+    serial: Option<Spinlock<serial::SerialPort>>,
 }
 
 impl LockedLogger {
     /// Create a new instance that logs to the given framebuffer.
-    pub fn new(
+    pub fn new(framebuffer: &'static mut [u8], info: FrameBufferInfo) -> Self {
-        framebuffer: &'static mut [u8],
+        let framebuffer = Some(Spinlock::new(framebuffer::FrameBufferWriter::new(
-        info: FrameBufferInfo,
+            framebuffer,
-    ) -> Self {
+            info,
-        let framebuffer = Some(Spinlock::new(framebuffer::FrameBufferWriter::new(framebuffer, info)));
+        )));
         let serial = Some(Spinlock::new(unsafe { serial::SerialPort::init() }));
 
         LockedLogger {
             framebuffer,
-            serial
+            serial,
         }
     }
 
@@ -65,16 +65,8 @@ impl log::Log for LockedLogger {
 }
 
 /// Initialize a text-based logger using the given pixel-based framebuffer as output.
-pub fn init_logger(
+pub fn init_logger(framebuffer: &'static mut [u8], info: FrameBufferInfo) {
-    framebuffer: &'static mut [u8],
+    let logger = LOGGER.get_or_init(move || LockedLogger::new(framebuffer, info));
-    info: FrameBufferInfo,
-) {
-    let logger = LOGGER.get_or_init(move || {
-        LockedLogger::new(
-            framebuffer,
-            info,
-        )
-    });
     log::set_logger(logger).expect("logger already set");
     #[cfg(debug_assertions)]
     log::set_max_level(log::LevelFilter::Debug);
@@ -82,14 +74,9 @@ pub fn init_logger(
     #[cfg(not(debug_assertions))]
     log::set_max_level(log::LevelFilter::Info);
 
-    log::debug!("Framebuffer info: {:?}", info);
+    log::debug!("Framebuffer info: {info:?}");
 }
 
 pub fn force_unlock() {
-    unsafe {
+    unsafe { LOGGER.get().map(|l| l.force_unlock()) };
-        LOGGER
-            .get()
-            .map(|l| l.force_unlock())
-    };
 }
-

kernel/src/logging/mod.rs

@@ -1,4 +1,5 @@
 pub mod logger;
+
 mod framebuffer;
 mod serial;
 

src/main.rs

@@ -4,16 +4,18 @@ fn main() {
     // read env variables that were set in build script
     let uefi_path = env!("UEFI_PATH");
     let bios_path = env!("BIOS_PATH");
-    
+
     // choose whether to start the UEFI or BIOS image
     let uefi = true;
 
     let mut cmd = std::process::Command::new("qemu-system-x86_64");
     if uefi {
         cmd.arg("-bios").arg(ovmf_prebuilt::ovmf_pure_efi());
-        cmd.arg("-drive").arg(format!("format=raw,file={uefi_path}"));
+        cmd.arg("-drive")
+            .arg(format!("format=raw,file={uefi_path}"));
     } else {
-        cmd.arg("-drive").arg(format!("format=raw,file={bios_path}"));
+        cmd.arg("-drive")
+            .arg(format!("format=raw,file={bios_path}"));
     }
     let mut child = cmd.spawn().unwrap();
     child.wait().unwrap();